Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G blue theme added #2205

Closed
wants to merge 4 commits into from
Closed

G blue theme added #2205

wants to merge 4 commits into from

Conversation

AmardeepKesharwani
Copy link

@AmardeepKesharwani AmardeepKesharwani commented Oct 17, 2022 •
edited
Loading

image
new theme has been added

@vercel
Copy link

vercel bot commented Oct 17, 2022

@AmardeepKesharwani is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Oct 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited
Loading

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ meko_blue

Result: ✔️ All themes are valid.

Details

Meko_blue theme preview

title_color: #080218 | icon_color: #170944 | text_color: #20096a | bg_color: #e3dfee

Preview Link

github-actions[bot]
github-actions bot requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some themes are invalid. See the Automated Theme Preview comment above for more information.

@github-actions github-actions bot added the invalid The bug/issue caused by minor mistakes. label Oct 17, 2022
@github-actions github-actions bot removed the invalid The bug/issue caused by minor mistakes. label Oct 17, 2022
ParthJadhav
ParthJadhav approved these changes Oct 18, 2022
View reviewed changes
Copy link

@ParthJadhav ParthJadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 18, 2022 •
edited
Loading

@ParthJadhav, to prevent the theme database from cluttering, we currently only merge themes from popular VScode themes or that have multiple upvotes. To merge this theme faster, it is best to add a 👍🏻 to the PR (see #1935).

@ParthJadhav
Copy link

Alrighty @rickstaa, Will keep that in mind.

@rickstaa rickstaa force-pushed the master branch 2 times, most recently from 86aafe8 to 8bc69e7 Compare January 21, 2023 16:47
@AmardeepKesharwani AmardeepKesharwani closed this by deleting the head repository Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@ParthJadhav ParthJadhav ParthJadhav approved these changes

Assignees
No one assigned
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmardeepKesharwani @rickstaa @ParthJadhav